Skip to content

Conversation

damcou
Copy link
Contributor

@damcou damcou commented Aug 26, 2025

This PR contains:

  • Some cleaning on the Queue and Job models
  • A new way of calculating maximum batch size in the queue, now we take into account the values defined at store level instead of the default one. This allows to take the values set by the batching optimizer into consideration.
  • Added some missing store scopings
  • Fixed a merge test

@damcou damcou requested a review from cammonro August 26, 2025 07:57
@damcou damcou self-assigned this Aug 26, 2025
@damcou damcou changed the title MAGE-1100: Indexing Queue updates MAGE-1110: Indexing Queue updates Aug 26, 2025
Copy link
Contributor

@cammonro cammonro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice progress on cleaning up this code! I do have a few concerns if you wouldn't mind taking a look. Additional comments in Jira.

@damcou damcou requested a review from cammonro August 27, 2025 09:23
Copy link
Contributor

@cammonro cammonro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further discussion in Jira detailing possible follow up action items but I'm ok with this iteration of the code. Approved!

@damcou damcou merged commit f5344d7 into release/3.17.0-dev Aug 28, 2025
4 checks passed
@damcou damcou deleted the feat/MAGE-1100-queue-updates branch August 28, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants