Skip to content

Fix #3098 #3274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix #3098 #3274

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9337c7d
fix(schematics): deploy - give child processes proper access to env v…
fr-esco Oct 7, 2022
6836b4d
fix(schematics): deploy - fix path to main.js (#3098)
fr-esco Oct 7, 2022
d817a7f
Merge branch 'master' into fix-3098
fr-esco Dec 28, 2022
1c6d5e5
Merge branch 'master' into fix-3098
davideast Jun 23, 2023
9de9945
Merge branch 'master' into fix-3098
davideast Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/schematics/deploy/actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ const spawnAsync = async (
) =>
new Promise<Buffer>((resolve, reject) => {
const [spawnCommand, ...args] = command.split(/\s+/);
options = { ...(options || {}), shell: true };
const spawnProcess = spawn(spawnCommand, args, options);
const chunks: Buffer[] = [];
const errorChunks: Buffer[] = [];
Expand Down Expand Up @@ -315,7 +316,8 @@ export const deployToCloudRun = async (
fsHost.copySync(staticOut, newStaticOut);
fsHost.copySync(serverOut, newServerOut);

const packageJson = getPackageJson(context, workspaceRoot, options, join(serverBuildOptions.outputPath, 'main.js'));
// Target runtime is Linux based.
const packageJson = getPackageJson(context, workspaceRoot, options, [serverBuildOptions.outputPath, 'main.js'].join('/'));
const nodeVersion = packageJson.engines.node;

if (!satisfies(process.versions.node, nodeVersion.toString())) {
Expand Down