Skip to content

Conversation

krummas
Copy link
Member

@krummas krummas commented Aug 15, 2025

Thanks for sending a pull request! Here are some tips if you're new here:

  • Ensure you have added or run the appropriate tests for your PR.
  • Be sure to keep the PR description updated to reflect all changes.
  • Write your PR title to summarize what this PR proposes.
  • If possible, provide a concise example to reproduce the issue for a faster review.
  • Read our contributor guidelines
  • If you're making a documentation change, see our guide to documentation contribution

Commit messages should follow the following format:

<One sentence description, usually Jira title or CHANGES.txt summary>

<Optional lengthier description (context on patch)>

patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####

Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>

The Cassandra Jira

@@ -737,7 +738,7 @@ public void serialize(ColumnMetadata t, DataOutputPlus out, Version version) thr
ColumnConstraints.serializer.serialize(t.columnConstraints, out, version);
}
if (version.isAtLeast(Version.V7))
out.writeInt(t.uniqueId);
out.writeVInt32(t.uniqueId);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the value is defined as int nextId = Math.max(0, maxAssignedUniqueId + 1);

so should we use unsigned vint?

Copy link
Contributor

@dcapwell dcapwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. I do think the uniqueId can also be a vint, but if you feel otherwise this works for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants