Skip to content

Conversation

jbampton
Copy link
Member

@jbampton jbampton commented Aug 6, 2025

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

https://github.com/jbampton/cloudstack/blob/00c9fcea78b1786702c1ce8d4af942d4839a4e30/README.md

Screenshot from 2025-08-06 23-25-03

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.35%. Comparing base (f020b5b) to head (00c9fce).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #11406   +/-   ##
=========================================
  Coverage     17.35%   17.35%           
+ Complexity    15230    15229    -1     
=========================================
  Files          5885     5885           
  Lines        525626   525626           
  Branches      64160    64160           
=========================================
  Hits          91217    91217           
  Misses       424112   424112           
  Partials      10297    10297           
Flag Coverage Δ
uitests 3.63% <ø> (ø)
unittests 18.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the README documentation by reorganizing and expanding the workflow status badges. The change improves the visibility of CI/CD pipeline statuses by separating badges onto individual lines and adding missing workflow badges.

Key changes:

  • Reorganizes existing badges from a single long line to multiple lines for better readability
  • Adds new workflow badges for Docker CloudStack Simulator, Linter, and Merge Conflict Checker
  • Updates the linter workflow name from "Lint" to "pre-commit"

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
README.md Reformats and expands workflow status badges with better organization and additional coverage
.github/workflows/linter.yml Updates workflow name to match the badge reference in README

# Apache CloudStack

[![Build Status](https://github.com/apache/cloudstack/actions/workflows/build.yml/badge.svg?branch=main)](https://github.com/apache/cloudstack/actions/workflows/build.yml)
[![codecov](https://codecov.io/gh/apache/cloudstack/branch/main/graph/badge.svg?branch=main)](https://codecov.io/gh/apache/cloudstack)
Copy link
Preview

Copilot AI Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The codecov badge URL contains redundant branch parameter. The URL already includes '/branch/main' in the path, so the '?branch=main' query parameter is unnecessary and should be removed for cleaner URLs.

Suggested change
[![codecov](https://codecov.io/gh/apache/cloudstack/branch/main/graph/badge.svg?branch=main)](https://codecov.io/gh/apache/cloudstack)
[![codecov](https://codecov.io/gh/apache/cloudstack/branch/main/graph/badge.svg)](https://codecov.io/gh/apache/cloudstack)

Copilot uses AI. Check for mistakes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this one goes for all the badges.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a question and a remark

@@ -15,7 +15,7 @@
# specific language governing permissions and limitations
# under the License.

name: Lint
name: pre-commit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the significance of this change?

# Apache CloudStack

[![Build Status](https://github.com/apache/cloudstack/actions/workflows/build.yml/badge.svg?branch=main)](https://github.com/apache/cloudstack/actions/workflows/build.yml)
[![codecov](https://codecov.io/gh/apache/cloudstack/branch/main/graph/badge.svg?branch=main)](https://codecov.io/gh/apache/cloudstack)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this one goes for all the badges.

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants