-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add all workflow buttons to README #11406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11406 +/- ##
=========================================
Coverage 17.35% 17.35%
+ Complexity 15230 15229 -1
=========================================
Files 5885 5885
Lines 525626 525626
Branches 64160 64160
=========================================
Hits 91217 91217
Misses 424112 424112
Partials 10297 10297
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the README documentation by reorganizing and expanding the workflow status badges. The change improves the visibility of CI/CD pipeline statuses by separating badges onto individual lines and adding missing workflow badges.
Key changes:
- Reorganizes existing badges from a single long line to multiple lines for better readability
- Adds new workflow badges for Docker CloudStack Simulator, Linter, and Merge Conflict Checker
- Updates the linter workflow name from "Lint" to "pre-commit"
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
README.md | Reformats and expands workflow status badges with better organization and additional coverage |
.github/workflows/linter.yml | Updates workflow name to match the badge reference in README |
# Apache CloudStack | ||
|
||
[](https://github.com/apache/cloudstack/actions/workflows/build.yml) | ||
[](https://codecov.io/gh/apache/cloudstack) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The codecov badge URL contains redundant branch parameter. The URL already includes '/branch/main' in the path, so the '?branch=main' query parameter is unnecessary and should be removed for cleaner URLs.
[](https://codecov.io/gh/apache/cloudstack) | |
[](https://codecov.io/gh/apache/cloudstack) |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this one goes for all the badges.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just a question and a remark
@@ -15,7 +15,7 @@ | |||
# specific language governing permissions and limitations | |||
# under the License. | |||
|
|||
name: Lint | |||
name: pre-commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the significance of this change?
# Apache CloudStack | ||
|
||
[](https://github.com/apache/cloudstack/actions/workflows/build.yml) | ||
[](https://codecov.io/gh/apache/cloudstack) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this one goes for all the badges.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
https://github.com/jbampton/cloudstack/blob/00c9fcea78b1786702c1ce8d4af942d4839a4e30/README.md
How did you try to break this feature and the system with this change?