Skip to content

server: enable KVM volume and VM snapshot by default #11446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

server: enable KVM volume and VM snapshot by default #11446

wants to merge 3 commits into from

Conversation

rohityadavcloud
Copy link
Member

Given EL6/EL7 is deprecated now and most modern supported KVM distros ship newer versions of qemu, KVM volume and VM snapshot can be enabled by default.

Fixes #11445

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

@rohityadavcloud rohityadavcloud added this to the 4.22.0 milestone Aug 14, 2025
@rohityadavcloud
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov Codecov
Copy link

codecov bot commented Aug 14, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.36%. Comparing base (3d6ec29) to head (8bb7d90).

Files with missing lines Patch % Lines
...in/java/com/cloud/server/ManagementServerImpl.java 0.00% 1 Missing ⚠️
...om/cloud/storage/snapshot/SnapshotManagerImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               main   #11446   +/-   ##
=========================================
  Coverage     17.36%   17.36%           
+ Complexity    15237    15236    -1     
=========================================
  Files          5888     5888           
  Lines        525741   525740    -1     
  Branches      64164    64164           
=========================================
  Hits          91274    91274           
+ Misses       424167   424166    -1     
  Partials      10300    10300
Flag Coverage Δ
uitests 3.63% <ø> (ø)
unittests 18.40% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14624

slavkap
slavkap approved these changes Aug 14, 2025
View reviewed changes
Copy link
Contributor

@slavkap slavkap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.
Thanks for this change

@DaanHoogland
Copy link
Contributor

@blueorangutan test keepEnv

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-14062)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 57050 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11446-t14062-kvm-ol8.zip
Smoke tests completed. 144 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_13_retrieve_vr_default_files Error 1.12 test_diagnostics.py
test_14_retrieve_vr_one_file Error 1.12 test_diagnostics.py
test_15_retrieve_ssvm_default_files Error 1.12 test_diagnostics.py
test_16_retrieve_ssvm_single_file Error 1.12 test_diagnostics.py
test_17_retrieve_cpvm_default_files Error 0.11 test_diagnostics.py
test_18_retrieve_cpvm_single_file Error 1.12 test_diagnostics.py
test_01_deployVMInSharedNetwork Failure 433.85 test_network.py

sureshanaparti
sureshanaparti approved these changes Aug 15, 2025
View reviewed changes
Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

DaanHoogland
DaanHoogland approved these changes Aug 20, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

harikrishna-patnala
harikrishna-patnala reviewed Sep 3, 2025
View reviewed changes
rohityadavcloud and others added 3 commits September 3, 2025 16:07
@rohityadavcloud @harikrishna-patnala
server: enable KVM volume and VM snapshot by default
140645c 
Given EL6/EL7 is deprecated now and most modern supported KVM distros
ship newer versions of qemu, KVM volume and VM snapshot can be enabled
by default.

Fixes apache#11445

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@rohityadavcloud @harikrishna-patnala
server: fix upper to lowercase for query/usage
ecb3bb9 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@harikrishna-patnala
Move kvm.snapshot.enabled to ConfigKey
8bb7d90
@harikrishna-patnala harikrishna-patnala force-pushed the enable-kvm-snapshot-by-default branch from 3666263 to 8bb7d90 Compare September 3, 2025 10:37
@harikrishna-patnala
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14827

@rohityadavcloud
Copy link
Member Author

@blueorangutan test

@blueorangutan
Copy link

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-14202)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 56044 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11446-t14202-kvm-ol8.zip
Smoke tests completed. 145 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_vpc_site2site_vpn_multiple_options Failure 270.70 test_vpc_vpn.py

harikrishna-patnala
harikrishna-patnala approved these changes Sep 8, 2025
View reviewed changes
Copy link
Contributor

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@harikrishna-patnala harikrishna-patnala harikrishna-patnala approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@slavkap slavkap slavkap approved these changes

Assignees
No one assigned
Labels
component:management-server component:storage status:needs-testing
Projects
Apache CloudStack 4.22.0
Status: In Progress
Milestone
4.22.0
Development

Successfully merging this pull request may close these issues.

enable kvm VM snapshots by default
6 participants
@rohityadavcloud @blueorangutan @DaanHoogland @harikrishna-patnala @sureshanaparti @slavkap