-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add cleanup for tiers dropdown on assignVirtualMachine API form #11464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug where the selected tier field in the assignVirtualMachine
API form wasn't being cleared when switching between domains or accounts, causing previously selected tiers to remain visible even when they shouldn't be available for the new selection.
- Adds cleanup logic to reset the selected tier when domain/account changes
- Ensures the tier dropdown is properly refreshed when switching contexts
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11464 +/- ##
=========================================
Coverage 17.35% 17.35%
- Complexity 15230 15235 +5
=========================================
Files 5886 5886
Lines 525685 525686 +1
Branches 64159 64159
=========================================
+ Hits 91247 91256 +9
+ Misses 424138 424130 -8
Partials 10300 10300
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm, not sure if this is being called in some undesirable scenarios as well though.
Hi, Daan. As far as I checked, |
tested in qa. |
Description
On the
assignVirtualMachine
API form, when switching domains or accounts, the selected tier field isn't being cleaned up. For example, with thenw
tier ofadmin
account selected, when selecting theuser
account, thenw
tier remains as the selected one.Therefore, a fix was made in order to refresh the selected tier field whenever another domain or account is selected.
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
How Has This Been Tested?
A new
User
account and a newdomain-test
domain with aDomain Admin
account inside were created, as well as tiers for both accounts.admin
account andnw
tier;user
account and verified that the selected tier field was cleaned up on the form and the list was refreshed;domain-test
and verified that the selected tier field was cleaned up on the form and the list was refresh again.