UI: Add validator for CIDR being passed #11465
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11465 +/- ##
=========================================
Coverage 17.35% 17.35%
- Complexity 15230 15235 +5
=========================================
Files 5886 5886
Lines 525685 525701 +16
Branches 64159 64159
=========================================
+ Hits 91247 91258 +11
- Misses 424138 424144 +6
+ Partials 10300 10299 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
| @@ -417,7 +419,7 @@ export default { | |||
| }, | |||
| updateCidrRule () { | |||
| if (!this.selectedVpcOfferingHavingRoutedNetworkMode) { | |||
| this.rules.cidr = [{ required: true, message: this.$t('message.error.required.input') }] | |||
| this.rules.cidr = [{ validator: isValidIPv4Cidr }] | |||
There was a problem hiding this comment.
no more message or required?
shwstppr
reviewed
Aug 22, 2025
| @@ -417,7 +419,7 @@ export default { | |||
| }, | |||
| updateCidrRule () { | |||
| if (!this.selectedVpcOfferingHavingRoutedNetworkMode) { | |||
| this.rules.cidr = [{ required: true, message: this.$t('message.error.required.input') }] | |||
| this.rules.cidr = [{ validator: isValidIPv4Cidr }] | |||
There was a problem hiding this comment.
Suggested change
| this.rules.cidr = [{ validator: isValidIPv4Cidr }] | |
| this.rules.cidr = [{ required: true, message: this.$t('message.error.required.input') }, { validator: isValidIPv4Cidr, trigger: 'change' }] |
maybe
vishesh92
reviewed
Aug 29, 2025
| @@ -102,3 +102,25 @@ export function toCsv ({ keys = null, data = null, columnDelimiter = ',', lineDe | |||
|
|
|||
| return result | |||
| } | |||
|
|
|||
| export function isValidIPv4Cidr (rule, value) { | |||
| console.log('here') | |||
There was a problem hiding this comment.
Suggested change
| console.log('here') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes: #11405
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?