Skip to content

Conversation

abh1sar
Copy link
Collaborator

@abh1sar abh1sar commented Aug 20, 2025

Description

This PR fixes #11480

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Before fix:
Screenshot 2025-08-20 at 12 24 57 PM
Screenshot 2025-08-20 at 12 21 29 PM

After fix:
Screenshot 2025-08-20 at 12 23 05 PM
Screenshot 2025-08-20 at 12 23 45 PM

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Aug 20, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.35%. Comparing base (f2d6356) to head (9937c26).

Files with missing lines Patch % Lines
...rg/apache/cloudstack/backup/BackupManagerImpl.java 0.00% 1 Missing and 1 partial ⚠️
.../apache/cloudstack/backup/DummyBackupProvider.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main   #11485   +/-   ##
=========================================
  Coverage     17.35%   17.35%           
- Complexity    15230    15235    +5     
=========================================
  Files          5886     5886           
  Lines        525685   525687    +2     
  Branches      64159    64159           
=========================================
+ Hits          91247    91258   +11     
+ Misses       424138   424129    -9     
  Partials      10300    10300           
Flag Coverage Δ
uitests 3.63% <ø> (ø)
unittests 18.39% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@sureshanaparti
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14678

@abh1sar
Copy link
Collaborator Author

abh1sar commented Aug 22, 2025

@blueorangutan test

@blueorangutan
Copy link

@abh1sar a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-14101)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 55389 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11485-t14101-kvm-ol8.zip
Smoke tests completed. 144 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_migrate_vm_strict_tags_success Error 61.14 test_vm_strict_host_tags.py
test_02_migrate_vm_strict_tags_failure Error 5.70 test_vm_strict_host_tags.py
test_01_restore_vm_strict_tags_success Error 9.77 test_vm_strict_host_tags.py
test_02_restore_vm_strict_tags_failure Error 11.82 test_vm_strict_host_tags.py
test_01_scale_vm_strict_tags_success Error 9.77 test_vm_strict_host_tags.py
test_02_scale_vm_strict_tags_failure Error 9.83 test_vm_strict_host_tags.py
test_01_deploy_vm_on_specific_host_without_strict_tags Error 11.84 test_vm_strict_host_tags.py
test_02_deploy_vm_on_any_host_without_strict_tags Error 16.94 test_vm_strict_host_tags.py
test_03_deploy_vm_on_specific_host_with_strict_tags_success Error 8.86 test_vm_strict_host_tags.py
test_04_deploy_vm_on_any_host_with_strict_tags_success Error 17.09 test_vm_strict_host_tags.py
test_04_deploy_vnf_appliance Error 181.07 test_vnf_templates.py
test_04_deploy_vnf_appliance Error 181.08 test_vnf_templates.py
test_05_delete_vnf_template Error 1.10 test_vnf_templates.py
ContextSuite context=TestVnfTemplates>:teardown Error 1.20 test_vnf_templates.py

@abh1sar
Copy link
Collaborator Author

abh1sar commented Aug 25, 2025

None of the test failures are related to the change

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14721

@blueorangutan
Copy link

[SF] Trillian test result (tid-14111)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 49179 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11485-t14111-kvm-ol8.zip
Smoke tests completed. 146 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Admin dashboard shows made-up backup storage
5 participants