Skip to content

Conversation

NickCirculy
Copy link

Description

Heroku deprecated the Hobby-dev plan for Redis, this prevents "deploying" AppSmith on Heroku by using the install Template. Instead now Heroku expects a Mini plan.

Fixes # (issue)
Deployment issue.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

After changing the app.json to require: heroku-redis:mini i was able to install AppSmith on Heroku by using the template.

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

@welcome
Copy link

welcome bot commented Dec 28, 2022

Welcome to the Appsmith community! Thank you for your first pull request and making this project better. 🤗 Please make sure that you raise a review request so your code change does not go unnoticed.

@vercel
Copy link

vercel bot commented Dec 28, 2022

@NickCirculy is attempting to deploy a commit to the Appsmith Team on Vercel.

A member of the Team first needs to authorize it.

@NickCirculy NickCirculy deleted the patch-2 branch December 28, 2022 11:38
@NickCirculy NickCirculy restored the patch-2 branch December 28, 2022 11:38
@NickCirculy NickCirculy reopened this Dec 28, 2022
@mohanarpit mohanarpit requested a review from sum35h January 2, 2023 12:39
@mohanarpit mohanarpit changed the title refac: Change deprecated Redis plan on Heroku chore: Change deprecated Redis plan on Heroku Jan 2, 2023
@mohanarpit
Copy link
Member

@sum35h Can we please test the suggested template change on Heroku?

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

@github-actions github-actions bot added the Stale label Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants