Skip to content

fix: tooltip position on edge of screen #34518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: release
Choose a base branch
from
+7 −1
Open

fix: tooltip position on edge of screen #34518

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d9a1838
fix(Tooltip): Ensure tooltip stays within viewport boundaries
admirhusic Jun 25, 2024
1362d70
Merge branch 'refs/heads/release' into fix/tooltip-position-fix
admirhusic Jun 25, 2024
72b8045
Merge remote-tracking branch 'origin/release' into fix/tooltip-positi…
admirhusic Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion app/client/packages/design-system/widgets-old/src/Tooltip/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,13 @@ if (!portalContainer) {
function TooltipComponent(props: TooltipProps) {
const modifiers = useMemo(
() => ({
preventOverflow: { enabled: false },
preventOverflow: {
enabled: true,
boundariesElement: "viewport",
},
flip: {
enabled: true,
},
Comment on lines +78 to +84
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider Adding Comments for Clarity

While the code changes are effective, adding comments explaining why these specific modifiers were chosen could be beneficial for future maintenance. This is especially important as tooltips are a common UI component and these changes might have nuanced impacts on different parts of the application.

      preventOverflow: {
+       // Enable to prevent the tooltip from overflowing the viewport
        enabled: true,
+       // Set the boundary element to the viewport to ensure visibility
        boundariesElement: "viewport",
      },
      flip: {
+       // Enable flipping to adjust tooltip position dynamically
        enabled: true,
      },
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
preventOverflow: {
enabled: true,
boundariesElement: "viewport",
},
flip: {
enabled: true,
},
preventOverflow: {
// Enable to prevent the tooltip from overflowing the viewport
enabled: true,
// Set the boundary element to the viewport to ensure visibility
boundariesElement: "viewport",
},
flip: {
// Enable flipping to adjust tooltip position dynamically
enabled: true,
},

...props.modifiers,
}),
[props.modifiers],
Expand Down