Make py_console_script_binary compatible with symbolic macros
#3195
Conversation
janwinkler1
force-pushed
the
symb-macro
branch
from
c91459a to
d3d11ba
Compare
|
@aignas thank you for your review! sure, i am looking into it ATM. in the dev-guide i read that integration tests are discuraged. in c91459a i quickly tried to add a simpler build test, however that failed in CI, presumably because bazel 7 doesnt support symbolic macros. so do you think in this case it would be okay to add a new integration test and ignore (if possible) bazel 7 tests there? |
|
|
||
| if kwargs.pop("srcs", None): | ||
| fail("passing 'srcs' attribute to py_console_script_binary is unsupported") | ||
|
|
||
| py_console_script_gen( | ||
| name = "_{}_gen".format(name), | ||
| name = name + "_gen", |
There was a problem hiding this comment.
This is making the target as foo_gen instead of _foo_gen that it previously was.
There was a problem hiding this comment.
Yes, this naming change is intentional. The underscore prefix violates Bazel's symbolic macro naming rules. Per the documentation [1], targets created by a symbolic macro must be named either the same as the macro or prefixed by the macro name followed by _, ., or -. The new naming satisfies this requirement.
[1] https://bazel.build/extending/macros - "Naming conventions for targets created"
| @@ -73,13 +73,13 @@ def py_console_script_binary( | |||
| Defaults to empty string. | |||
| **kwargs: Extra parameters forwarded to `binary_rule`. | |||
| """ | |||
| main = "rules_python_entry_point_{}.py".format(name) | |||
| main = name + "_entry_point.py" | |||
There was a problem hiding this comment.
Just out of curiosity, could you please explain why you've selected to use this?
There was a problem hiding this comment.
This, too, is required for symbolic macro compatibility. The original .format() approach created filenames that also violated the naming rules [1].
[1] https://bazel.build/extending/macros - "Naming conventions for targets created"
Fixes target naming to follow symbolic macro conventions introduced in Bazel 8.0.