Fix #18 - Make colors more future-proof #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #18, by making colors based on the final release date of the SDK version.
That way, it should require less app maintenance (if none of us is there to do the yearly maintenance of
targetSdk), and if Google keeps the same release pace, colors should be good for about 2.5 years (up to 2027 Q2 if a SDK 37 is released in 2026 Q2).Note that since SDK 32 and SDK 33 were released at about the same time, they are now showing as the same orange color, which is the intended behavior if we are based on year since release.