Use a correct default value for half space initialization in from_clip_from_world_no_far #20703
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Testing
relative radius is a bunch of dot products with the frustum plane (which is 0) so it is 0.
normal dot aabb center again is 0, 0 + 0 is 0, which is <= 0. The if gets hit, and intersects returns false, wrongly.
Changing d to f32::MAX instead makes the normal_d dot center extended by 1 result in f32::MAX, which is not <= 0, and thus intersect can succeed