Fix compatibility with -debuglogfile command-line option
#884
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change avoids hardcoding the "debug.log" filename, ensuring compatibility with custom filenames provided via the `-debuglogfile` command-line option.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
|
Incorporated into bitcoin/bitcoin#33215. Closing. |
That PR is not actually ready.
Reopened. |
pablomartin4btc
approved these changes
Aug 22, 2025
There was a problem hiding this comment.
ACK c0d28c8
LogInstance().m_file_path is being set in init::SetLoggingOptions(args).
Need to restart some CIs (few were cancelled when PR got closed)?
|
tested ACK c0d28c8 💳 Show signatureSignature: |
|
(ci failure can be ignored, see bitcoin/bitcoin#33293) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change avoids hardcoding the "debug.log" filename, ensuring compatibility with custom filenames provided via the
-debuglogfilecommand-line option.