feat: integrate tool call icons with status indicators and daisy chaining #4279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add 17 custom tool call icon components (Terminal, FileEdit, Globe, etc.) - Create comprehensive tool-to-icon mapping system - Implement status indicator overlay system (success/error/loading/pending) - Replace old green dot status with integrated icon+status display - Remove redundant LoaderCircle and Dot components from tool calls - Maintain all existing functionality (tooltips, expansion, etc.) Visual improvements: - Each tool call now shows specific icon (11x11px matching design system) - Status indicators: green (success), red (error), yellow pulsing (loading), gray (pending) - Cleaner layout with single status indicator per tool - Better visual hierarchy and user experience Files added: - ui/desktop/src/components/icons/toolcalls/ (17 icon components) - ui/desktop/src/utils/toolIconMapping.tsx (mapping logic) - ui/desktop/src/components/ToolCallStatusIndicator.tsx (status system) Files modified: - ui/desktop/src/components/ToolCallWithResponse.tsx (integration)
Co-authored-by: dianed-square <73617011+dianed-square@users.noreply.github.com> Co-authored-by: Zane <75694352+zanesq@users.noreply.github.com>
Co-authored-by: dianed-square <73617011+dianed-square@users.noreply.github.com> Co-authored-by: Zane <75694352+zanesq@users.noreply.github.com>
spencrmartin
changed the title
|
Followed up with @chaitanyarahalkar around Chain-Of-Thought code block
for context. Moving to ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Tool Call Chaining
Consecutive tool calls are now visually grouped into chains
Reduces visual clutter by combining related tool executions
Smart chain detection that works during streaming
Preserves individual tool call functionality for non-chained calls
🎨 Tool Call Icons & Status Indicators
13 new custom icons for different tool types (Terminal, FileEdit, Globe, Camera, etc.)
Dynamic icon mapping based on tool names and functions
Status indicators showing tool execution state
Enhanced visual hierarchy for better UX
🧠 Preserved Core Functionality
Chain of Thought (CoT) with `` blocks maintained
GooseResponseForm integration preserved (currently disabled but available)
Metadata handling and parameter usage restored
Tool confirmations and error handling intact
🔧 Technical Changes
New Components
ToolCallChain.tsx - Handles rendering of chained tool calls
ToolCallStatusIndicator.tsx - Visual status indicators for tools
13 new icon components in icons/toolcalls/
Enhanced Components
GooseMessage.tsx - Integrated chaining logic while preserving CoT
ToolCallWithResponse.tsx - Enhanced with status indicators
New Utilities
toolCallChaining.ts - Chain detection and management logic
toolIconMapping.tsx - Dynamic icon assignment system
Original prework PR #4248