Add supprt for new c23 deallocators #817
Conversation
This commit introduces 2 new functions to add support for `free_sized` and `free_aligned_sized` deallocators introduced in c23. We ensure that `free_sized` and `free_aligned_sized` are skipped if unavailable otherwise we get a `FREE` record recorded for them. Signed-off-by: Nana Adjei Manu <n.k.a.manu06@gmail.com>
| FOR_EACH_HOOKED_FUNCTION(free_sized) \ | ||
| FOR_EACH_HOOKED_FUNCTION(free_aligned_sized) |
There was a problem hiding this comment.
These functions aren't platform specific, this should go into the #define MEMRAY_HOOKED_FUNCTIONS define below, not into MEMRAY_PLATFORM_HOOKED_FUNCTIONS. Also, you missed adding a \ to the previous line... What you've got here shouldn't compile...
There was a problem hiding this comment.
Since we're trying to test a C23 feature, we shouldn't be using a C++ source file. We need a .c file for this test, not a .cpp file
| subprocess.run( | ||
| [sys.executable, str(extension_path / "setup.py"), "build_ext", "--inplace"], | ||
| check=True, | ||
| cwd=extension_path, | ||
| capture_output=True, | ||
| ) |
There was a problem hiding this comment.
we probably also need to check that the compiler is able to build C23 stuff. If we get a compilation error here, we probably need to tell pytest to skip the test instead of failing it.
| for record in records | ||
| if record.address in mallocs_addr and record.allocator == AllocatorType.FREE | ||
| ] | ||
| assert len(frees) >= 2 |
There was a problem hiding this comment.
Wouldn't we want to check that len(frees) == len(mallocs)? That is, that every allocation was freed?
There was a problem hiding this comment.
Actually, what we probably want to do is have the functions in the extension module return the addresses that were allocated, so that the tests can ensure that a deallocation was seen for each of those addresses.
| assert records | ||
|
|
||
| # Check that at least 2 allocations from malloc and aligned_alloc | ||
| mallocs = [record for record in records if record.allocator == AllocatorType.MALLOC] |
There was a problem hiding this comment.
This won't find the allocation that was freed with free_aligned_sized - that allocation should have AllocatorType.ALIGNED_ALLOC instead.
closes #725
This commit introduces 2 new functions to add support for
free_sizedandfree_aligned_sizeddeallocators introduced in c23.Tests ensure that
free_sizedandfree_aligned_sizedare skipped if unavailable otherwise we get aFREErecord recorded for them.