fix: Custom Open AI services do not adhere to model selections #1090
+53
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@carlrobertoh I could completely eliminate the Anyway, let me know if you need any changes or don't like the fix. I'll see what I can do. Testing note: I tested switching custom services in all features except for Code Completion. I can´t get it to work with the custom services, it keeps stating my API key is incorrect and I should get it in the OpenAI console. I mean, I can try, but it still won't work :P |
|
How soon it will be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1089
My (second) hunch was correct. The
CustomOpenAIRequestFactoryas well as several points in the Code Completion logic referencedee.carlrobert.codegpt.settings.service.custom.CustomServicesState#getActivebut that property always contains the same (first) custom service definition state.