Skip to content

Conversation

christianbeeznest
Copy link
Contributor

No description provided.

@ywarnier
Copy link
Member

Looks good to me. I'm not sure what the e-mail of the fallback user is, though (where is it configured?)

@ywarnier
Copy link
Member

Although the code looks good, this doesn't seem to be what I would be expecting.

  • There is no place/process where we suggest to update the fallback user's e-mail address.
  • Sending with the sender's "reply-to" should not be the behavior by default (we should use the platform's address as reply-to, otherwise we encourage off-platform conversations, which we generally want to avoid)

So I'm not merging this PR for now. We need to discuss this more.

@christianbeeznest
Copy link
Contributor Author

Closing in favor of a revised approach aligned with #4283.
We should not use fallback_user in SMTP headers. Instead:

From/Reply-To come from platform settings (default Reply-To = platform).

fallback_user is used only for internal DB associations (ownership/creator reassignment, neutral sender inside Chamilo).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants