Skip to content

Conversation

JerrySentry
Copy link
Contributor

  • An edge case where sync repos hangs when a repo is renamed, a special rename pattern where the letters are the same but upper/lower casings are changed
  • This triggers a TriggeredDataChangeViolation with updating the name in sync repos and repos_before_insert_or_update. The trigger happens because the name field is citext so the where clause comparison is case insensitive.
  • The conflict happens when the trigger is setting name to null while the sync repo is setting to new string

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Aug 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.22%. Comparing base (8392c8b) to head (ef909bc).
⚠️ Report is 34 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #406   +/-   ##
=======================================
  Coverage   94.22%   94.22%           
=======================================
  Files        1257     1258    +1     
  Lines       46592    46597    +5     
  Branches     1491     1491           
=======================================
+ Hits        43901    43906    +5     
  Misses       2386     2386           
  Partials      305      305           
Flag Coverage Δ
apiunit 96.16% <ø> (ø)
sharedintegration 40.18% <0.00%> (-0.02%) ⬇️
sharedunit 89.00% <100.00%> (+<0.01%) ⬆️
workerintegration 61.44% <ø> (ø)
workerunit 90.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Aug 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

codspeed-hq bot commented Aug 14, 2025

CodSpeed Performance Report

Merging #406 will not alter performance

Comparing jerry/fix-sync-repo-rename (ef909bc) with main (0e9f5c4)1

Summary

✅ 9 untouched benchmarks

Footnotes

  1. No successful run was found on main (8392c8b) during the generation of this report, so 0e9f5c4 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@JerrySentry JerrySentry marked this pull request as ready for review August 15, 2025 14:32
@JerrySentry JerrySentry requested a review from a team as a code owner August 15, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants