Skip to content

Conversation

Kota-Jagadeesh
Copy link
Collaborator

This pull request fixes issue #6307 by making "Usages on Other Wikis" items clickable in the media details screen, opening the correct pages in the browser.

Changes:

  • Updated FileUsagesUiModel.kt to generate correct URLs for other wikis (e.g., https://en.wikipedia.org/wiki/Changi_East_Depot), handling full domains like en.wikipedia.org.
  • Added clickable functionality to "Usages on Other Wikis" in MediaDetailFragment.kt, with blue underlined text matching Commons usages.
  • Tested with images like File:Changi_East_Depot_site_080525.jpg to ensure links work.

Closes #6307.

@nicolas-raoul
Copy link
Member

Sorry my next 10 days are super busy, but we will come to this PR afterwards. Feel free to work on other bugs if you want. Thanks a lot for your patience! 🙂

@Kota-Jagadeesh
Copy link
Collaborator Author

Sorry my next 10 days are super busy, but we will come to this PR afterwards. Feel free to work on other bugs if you want. Thanks a lot for your patience! 🙂

Okay 👍🏻

@Kota-Jagadeesh
Copy link
Collaborator Author

Sorry my next 10 days are super busy, but we will come to this PR afterwards. Feel free to work on other bugs if you want. Thanks a lot for your patience! 🙂

@nicolas-raoul - Can you review my PR ?

@nicolas-raoul
Copy link
Member

Links work great now, thanks a lot!

I see domain names are now replaced with article name, which is good. The only small drawback is that for instance here we can't tell the difference between these articles:

Screenshot_20250902-105644.png

How about prefixing with for instance (en) or (fr) fr similar? Either in this PR, or I can create a new issue if you don't want to work on it. 🙂

Copy link

github-actions bot commented Sep 2, 2025

✅ Generated APK variants!

@Kota-Jagadeesh
Copy link
Collaborator Author

Links work great now, thanks a lot!

I see domain names are now replaced with article name, which is good. The only small drawback is that for instance here we can't tell the difference between these articles:

Screenshot_20250902-105644.png

How about prefixing with for instance (en) or (fr) fr similar? Either in this PR, or I can create a new issue if you don't want to work on it. 🙂

Can you please create a new issue for this? At the moment, I’m working on three Commons issues. I’ll get back to this one once I finish the tasks currently assigned to me in Commons. :)

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great, thanks!

@nicolas-raoul nicolas-raoul merged commit e2c8f85 into commons-app:main Sep 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make items in "File usages" clickable, opening page where the image is used
2 participants