Skip to content

Problem: total supply mismatch when miss CreditVirtualAccounts #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Problem: total supply mismatch when miss CreditVirtualAccounts #582

wants to merge 2 commits into from

Conversation

mmsqe
Copy link

@mmsqe mmsqe commented Apr 16, 2025

miss EndBlock function calls before SimWriteState

Closes: #XXX

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@mmsqe
Problem: total supply mismatch when miss CreditVirtualAccounts
4327bab 
miss EndBlock function calls before SimWriteState
@socket-security Socket Security
Copy link

socket-security bot commented Apr 16, 2025 •
edited
Loading

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Addedgolang/​github.com/​mmsqe/​cosmos-sdk@​v0.46.0-beta2.0.20250416020250-a91a1c28438076100100100100
Updatedgolang/​github.com/​stretchr/​testify@​v1.9.0 ⏵ v1.10.081100100100100
Updatedgolang/​github.com/​spf13/​cast@​v1.6.0 ⏵ v1.7.110010010010080
Updatedgolang/​cosmossdk.io/​math@​v1.3.0 ⏵ v1.4.0100 +1100 +16100100100
Updatedgolang/​github.com/​cosmos/​cosmos-db@​v1.0.3-0.20240408151834-e75f6e4b28d8 ⏵ v1.1.1100100100100100

View full report

@thomas-nguy
Copy link

To fix the simtest (from sdk backport fixes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmsqe @thomas-nguy