Skip to content

Conversation

igorlukanin
Copy link
Member

@igorlukanin igorlukanin commented Jul 17, 2025

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@igorlukanin igorlukanin requested a review from KSDaemon July 17, 2025 16:24
@igorlukanin igorlukanin added the docs Issues that require a documentation improvement label Jul 17, 2025
Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Nice work!

I left some typos and questions that I hope you'll find useful.

# ...
</CodeTabs>

#### `time_dimension`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about a named time shift specification?

type: count
public: false
```
### `time_shift`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but...
There is no info about relation between measure timeshifts and calendar cubes: how they are related, how matching happens, and how it is processed from the calendar's td definition: if interval+type are defined and when sql is defined.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, it's been described in calendar cubes, but I think it would be useful to at least mention such options here with the link to the full description there...

type: time

time_shift:
- type: prior
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no named examples: name + sql and name + interval + type

igorlukanin and others added 2 commits August 18, 2025 13:05
Co-authored-by: Konstantin Burkalev <KSDaemon@gmail.com>
Co-authored-by: Konstantin Burkalev <KSDaemon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues that require a documentation improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants