-
Notifications
You must be signed in to change notification settings - Fork 151
feat(xyz): add extended XYZ format alias #881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Conversation
Co-authored-by: njzjz <9496702+njzjz@users.noreply.github.com>
…dback Co-authored-by: njzjz <9496702+njzjz@users.noreply.github.com>
@copilot please add tests to confirm the dumped extxyz could be read by ASE, and ASE dumped extxyz could be loaded by dpdata. Please also add the following alias: gpumd, nequip, and mace. |
…iases (gpumd, nequip, mace) Co-authored-by: njzjz <9496702+njzjz@users.noreply.github.com>
I've added comprehensive ASE cross-compatibility tests and the requested format aliases. The implementation includes:
Commit: c2ba8f7 |
…handling per reviewer feedback Co-authored-by: njzjz <9496702+njzjz@users.noreply.github.com>
…opagate as test failures Co-authored-by: njzjz <9496702+njzjz@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #881 +/- ##
==========================================
+ Coverage 85.45% 85.81% +0.36%
==========================================
Files 82 82
Lines 7678 7713 +35
==========================================
+ Hits 6561 6619 +58
+ Misses 1117 1094 -23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
@copilot please also check energies and forces are correct. There is an useful utility |
…mpatibility using CompLabeledSys Co-authored-by: njzjz <9496702+njzjz@users.noreply.github.com>
I've added comprehensive energy and force verification tests using the CompLabeledSys utility. The new TestExtXYZEnergyForceCompatibility class verifies that energies and forces are correctly preserved through the dpdata ↔ ASE round-trip conversion process:
The test demonstrates that the extxyz format correctly preserves physical properties during cross-compatibility operations between dpdata and ASE. Commit: 68a45a2 |
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@ustc.edu.cn>
CodSpeed WallTime Performance ReportMerging #881 will not alter performanceComparing Summary
Footnotes |
This PR adds extended XYZ format support and comprehensive cross-compatibility testing with ASE (Atomic Simulation Environment), including rigorous verification of energy and force preservation.
Changes Made
extxyz
now aliases to the existing QuipGapXYZFormat implementationgpumd
,nequip
, andmace
all point to the same QuipGapXYZFormat for compatibilityCompLabeledSys
utility to rigorously verify that energies and forces are correctly preserved through dpdata ↔ ASE round-trip conversion:Example Usage
The implementation leverages existing code without duplicating functionality, providing multiple entry points for the same robust extended XYZ format handling while ensuring full compatibility with ASE's extxyz implementation.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.