Skip to content

Support float step sizes and enforce validation in the set_step method for Number field #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support float step sizes and enforce validation in the set_step method for Number field #132

wants to merge 2 commits into from

Conversation

jaakkolehtonen
Copy link
Contributor

  • Updated set_step to allow float step sizes
  • Added validation to ensure the step size is a positive numeric value, as negative step sizes have no effect in the step attribute of HTML inputs

@jaakkolehtonen
Copy link
Contributor Author

jaakkolehtonen commented Dec 4, 2024 •
edited
Loading

This change also resolves the PHP 8.1 deprecation notice for implicit conversion from float to int when the passed value is a float.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jaakkolehtonen