-
-
Notifications
You must be signed in to change notification settings - Fork 20
feat: ListEmailTemplates for SES v2 #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I'm happy to approve:
- Adding the list templates endpoint
- Changing the start script to use nodemon, although I'd probably keep
npm start
(with nodemon) as the recommended path in README
I think I'm less sold on devcontainers after using them a bit more for some other projects. While they're nice for some setup, they can also cause lag/slowness, and pain about port forwarding on different systems. Maybe we can spin that out as a separate PR that we can discuss more there?
c7ae195
to
1c9dbca
Compare
Dropped: bffb870 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks 🙌
Releasd in v2.8.0 |
Resolves: #58 / Fixes: #51
In addition, I've set up Dev Container to facilitate development.Demo