-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Disable tests parallelization in flaky OleDB tests #119018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @roji, @SamMonoRT |
fb60001
to
963fc33
Compare
Attempts to fix dotnet#87783
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses flaky OleDB tests by disabling test parallelization to work around concurrency issues in the ACE/Access OleDB driver.
- Adds an AssemblyInfo.cs file to disable test parallelization for the OleDB test suite
- Implements a temporary workaround for known concurrency issues in the Microsoft ACE OleDB driver
@jeffschwMSFT @jeffhandley @SamMonoRT ping - this is a tiny PR that may solve the OleDB test flakiness that's been plaguing us, would be great to get it in (I'll backport to release/10.0). If this doesn't solve the problem I'll continue to look further. |
@roji - did we ever submit a backport PR - The RC2 window is closing, making sure we get that in time. |
There's reason to believe that the flakiness in #87783 is caused by concurrency issues in the ACE/Access OleDB driver being used (e.g. here). So as an easy attempt to get rid of the flakiness, I'm disabling parallelization altogether in these tests. I suggest we merge this and observe what happens in the next few days/weeks.
If this doesn't fix the flakiness, we should move away from ACE to SQL Server / LocalDB. There's a good chance we'd need to install components on the runner image though, so we'd probably want to skip the tests until that happens.
@jeffschwMSFT @jeffhandley @SamMonoRT