Skip to content

[StaticWebAssets] Use property for original resource #50420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[StaticWebAssets] Use property for original resource #50420

wants to merge 8 commits into from

Conversation

javiercn
Copy link
Member

We were attaching a weak ETag to compressed resources. We removed it as part of a fix because it was causing issues with some HTTP Clients, but we were using it during development to match a compressed resource with its original representation.

This fix removes the usage of the weak ETag for 10.0 and onwards (9.0 will still emit the weak ETag for backwards compatibility) and 10.0 will instead use an original-resource endpoint property for the matching.

@github-actions github-actions bot added the Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch label Aug 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

This PR is targeting main, which is now for .NET 11-facing work. If you intended to target .NET 10, either retarget this PR to release/10.0.1xx or make sure you backport the change to release/10.0.1xx after merging. See #50394 for more details.

@javiercn javiercn force-pushed the javiercn/use-property-for-original-resource branch from 8ee2eac to e0067d0 Compare August 21, 2025 21:57
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Thanks for your PR, @@javiercn.
To learn about the PR process and branching schedule of this repo, please take a look at the SDK PR Guide.

This was referenced Aug 22, 2025
Open
Open
@javiercn javiercn force-pushed the javiercn/use-property-for-original-resource branch from 7bb21fc to e52060c Compare August 22, 2025 10:40
This was referenced Aug 22, 2025
Open
Open
@javiercn javiercn requested a review from maraf August 22, 2025 12:15
maraf
maraf approved these changes Aug 22, 2025
View reviewed changes
@javiercn @maraf
Update src/StaticWebAssetsSdk/Targets/Microsoft.NET.Sdk.StaticWebAsse…
42a0ba3 
…ts.Compression.targets

Co-authored-by: Marek Fišera <mara@neptuo.com>
@javiercn
Copy link
Member Author

/backport to release/10.0.1xx-rc2

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/10.0.1xx-rc2: https://github.com/dotnet/sdk/actions/runs/17157606855

@github-actions GitHub Actions
Copy link
Contributor

@javiercn an error occurred while backporting to "release/10.0.1xx-rc2", please check the run log for details!

Error: The specified backport target branch "release/10.0.1xx-rc2" wasn't found in the repo.

@javiercn
Copy link
Member Author

/backport to release/10.0.1xx-rc1

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/10.0.1xx-rc1: https://github.com/dotnet/sdk/actions/runs/17158173348

@github-actions github-actions bot mentioned this pull request Aug 22, 2025
Closed
10 tasks
@build-analysis build-analysis bot mentioned this pull request Aug 22, 2025
Open
3 tasks
@javiercn javiercn marked this pull request as ready for review August 22, 2025 16:06
@Copilot Copilot AI review requested due to automatic review settings August 22, 2025 16:06
@javiercn javiercn requested a review from tmat as a code owner August 22, 2025 16:06
@javiercn javiercn requested review from a team as code owners August 22, 2025 16:06
Copilot
Copilot AI reviewed Aug 22, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@javiercn
Copy link
Member Author

/backport to release/10.1xx

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/10.1xx: https://github.com/dotnet/sdk/actions/runs/17174844908

@github-actions GitHub Actions
Copy link
Contributor

@javiercn an error occurred while backporting to "release/10.1xx", please check the run log for details!

Error: The specified backport target branch "release/10.1xx" wasn't found in the repo.

@javiercn
Copy link
Member Author

/backport to release/10.0.1xx

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/10.0.1xx: https://github.com/dotnet/sdk/actions/runs/17174854533

@github-actions github-actions bot mentioned this pull request Aug 23, 2025
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@maraf maraf maraf approved these changes

@tmat tmat Awaiting requested review from tmat tmat is a code owner

Assignees
No one assigned
Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@javiercn @maraf