-
Notifications
You must be signed in to change notification settings - Fork 1k
Fix TextBoxBase related BackColor issues #13820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13820 +/- ##
===================================================
- Coverage 77.10744% 77.10282% -0.00463%
===================================================
Files 3273 3273
Lines 644882 644883 +1
Branches 47686 47686
===================================================
- Hits 497252 497223 -29
- Misses 143951 143988 +37
+ Partials 3679 3672 -7
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved and Servicing approved.
Going to merge immediately.
@Epica3055 - we need to dual check-in this one to the RC1/2/GA branch. |
/backport to release/10.0-rc1 |
Started backporting to release/10.0-rc1: https://github.com/dotnet/winforms/actions/runs/17254890635 |
/backport to release/10.0 |
Started backporting to release/10.0: https://github.com/dotnet/winforms/actions/runs/17425224821 |
Backport of #13820 to release/10.0 /cc @Epica3055 ## Proposed changes - add a condition whether there is a specified color or not ## fixed Controls TextBox, DomainUpDown, NumericUpDown, RichTextBox, MaskedTextBox <!-- ## Customer Impact - - ## Regression? - Yes / No ## Risk - --> ## Screenshots <!-- Remove this section if PR does not change UI --> ### Before <img width="516" height="549" alt="image" src="https://github.com/user-attachments/assets/4e48b944-20bd-4ddf-86e7-c41ba3256cd5" /> ### After <img width="568" height="553" alt="image" src="https://github.com/user-attachments/assets/228983f4-92da-4f81-97a2-455411b038e2" /> ## Test methodology <!-- How did you ensure quality? --> - manual
related to #13813
Proposed changes
fixed Controls
TextBox, DomainUpDown, NumericUpDown, RichTextBox, MaskedTextBox
Screenshots
Before
After
Test methodology