Skip to content

Conversation

Epica3055
Copy link
Member

@Epica3055 Epica3055 commented Aug 19, 2025

related to #13813

Proposed changes

  • add a condition whether there is a specified color or not

fixed Controls

TextBox, DomainUpDown, NumericUpDown, RichTextBox, MaskedTextBox

Screenshots

Before

image

After

image

Test methodology

  • manual

Copy link

codecov bot commented Aug 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.10282%. Comparing base (93a2ef9) to head (1a8e8b1).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #13820         +/-   ##
===================================================
- Coverage   77.10744%   77.10282%   -0.00463%     
===================================================
  Files           3273        3273                 
  Lines         644882      644883          +1     
  Branches       47686       47686                 
===================================================
- Hits          497252      497223         -29     
- Misses        143951      143988         +37     
+ Partials        3679        3672          -7     
Flag Coverage Δ
Debug 77.10282% <100.00000%> (-0.00463%) ⬇️
integration 18.98546% <100.00000%> (-0.00391%) ⬇️
production 51.91376% <100.00000%> (-0.01026%) ⬇️
test 97.41248% <ø> (ø)
unit 49.33336% <100.00000%> (-0.00644%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KlausLoeffelmann KlausLoeffelmann changed the title fix TextBoxBase related Controls backColor problems Fix TextBoxBase related BackColor issues Aug 19, 2025
@KlausLoeffelmann KlausLoeffelmann added servicing-consider .NET Shiproom label indicating a PR seeks to enter into a branch under Tell-Mode criteria area-DarkMode Issues relating to Dark Mode feature and removed needs-area-label labels Aug 19, 2025
@rbhanda rbhanda added servicing-approved .NET Shiproom approved the PR for merge and removed servicing-consider .NET Shiproom label indicating a PR seeks to enter into a branch under Tell-Mode criteria labels Aug 21, 2025
Copy link
Member

@KlausLoeffelmann KlausLoeffelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved and Servicing approved.
Going to merge immediately.

@KlausLoeffelmann KlausLoeffelmann merged commit 3774d9f into main Aug 26, 2025
9 checks passed
@KlausLoeffelmann KlausLoeffelmann deleted the Fix_13813_2 branch August 26, 2025 16:30
@KlausLoeffelmann
Copy link
Member

KlausLoeffelmann commented Aug 26, 2025

@Epica3055 - we need to dual check-in this one to the RC1/2/GA branch.
Could you do that, so I can merge tomorrow morning my time?

@Epica3055
Copy link
Member Author

/backport to release/10.0-rc1

Copy link
Contributor

Started backporting to release/10.0-rc1: https://github.com/dotnet/winforms/actions/runs/17254890635

@Epica3055
Copy link
Member Author

/backport to release/10.0

Copy link
Contributor

github-actions bot commented Sep 3, 2025

Started backporting to release/10.0: https://github.com/dotnet/winforms/actions/runs/17425224821

KlausLoeffelmann added a commit that referenced this pull request Sep 4, 2025
Backport of #13820 to release/10.0

/cc @Epica3055

## Proposed changes

- add a condition whether there is a specified color or not


## fixed Controls
TextBox, DomainUpDown, NumericUpDown, RichTextBox, MaskedTextBox 

<!-- 

## Customer Impact

- 
- 

## Regression? 

- Yes / No

## Risk

-

 -->


## Screenshots <!-- Remove this section if PR does not change UI -->

### Before

<img width="516" height="549" alt="image"
src="https://github.com/user-attachments/assets/4e48b944-20bd-4ddf-86e7-c41ba3256cd5"
/>

### After

<img width="568" height="553" alt="image"
src="https://github.com/user-attachments/assets/228983f4-92da-4f81-97a2-455411b038e2"
/>


## Test methodology <!-- How did you ensure quality? -->

- manual
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-DarkMode Issues relating to Dark Mode feature servicing-approved .NET Shiproom approved the PR for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants