feat(search_family): Add LOAD_FROM to the FT.AGGREGATE command #5703
+881
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it's huge. Is it possible to split it somehow? |
I left a comment in the PR description regarding the number of code lines. This is the second PR; once the first one is merged, the number of lines will be much lower. |
Signed-off-by: Stepan Bagritsevich <stefan@dragonflydb.io>
BagritsevichStepan
force-pushed
the
search/ft-aggregate-load-from
branch
from
7e26a02 to
37ad2ee
Compare
| @@ -27,7 +27,7 @@ using Value = ::dfly::search::SortableValue; | |||
|
|
|||
| // DocValues sent through the pipeline | |||
| // TODO: Replace DocValues with compact linear search map instead of hash map | |||
| using DocValues = absl::flat_hash_map<std::string_view, Value>; | |||
| using DocValues = absl::flat_hash_map<std::string, Value>; | |||
There was a problem hiding this comment.
It is temporary and will be fixed in next PRs
dranikpg
previously approved these changes
Aug 24, 2025
Signed-off-by: Stepan Bagritsevich <stefan@dragonflydb.io>
Fixed and added this case to the tests |
dranikpg
approved these changes
Aug 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Join index_join with the FT.AGGREGATE command.
First PR is #5604
Most of the lines are from prev PR and also I added a lot of tests. Real number of lines is not so big