fix: improve connection management in app lifespan #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add connection state tracking to prevent disconnect errors - Only attempt disconnect if client was successfully connected - Add exception handling for cleanup operations to prevent crashes - Resolves potential issues during server shutdown when connection fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes connection management issues in the MCP server's lifespan handler that could cause crashes during shutdown.
Changes
Type of Change
Checklist
Related Issues
Additional Notes
This is a defensive programming fix that improves the reliability of the MCP server. The change is backward compatible and only affects the cleanup behavior during shutdown. Users will experience more stable server operation,
especially in environments with network issues or configuration problems.