Address a bunch of code-analysis quick fixes #1761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cotti
approved these changes
Aug 26, 2025
Mpdreamz
added a commit
that referenced
this pull request
Aug 26, 2025
Mpdreamz
added a commit
that referenced
this pull request
Aug 26, 2025
* Allow relative path handling in diff validation and enhance root determination - Updated `ValidateRedirects` method to support relative paths. - Improved handling of source directory root in diff validation. - Fixed path normalization in `IntegrationGitRepositoryTracker`. * Do not pop unrelated changes * Refactor `RedirectFile` initialization and enhance `IRepositoryTracker` for improved redirect handling - Simplified `RedirectFile` creation logic and constructor overloading. - Changed `IRepositoryTracker` to return a `IReadOnlyCollection` for consistency. - Enhanced path normalization across repository trackers. - Adjusted dependent tests and updated related YAML documentation. * Exclude `_snippets` folder from missing redirects detection in `DiffCommands` * Add HasParent extension method on IFileInfo and IDirectoryInfo * Only consider markdown file changes * use string.Equals * update logging * update filter, include markdowns without parent _snippet folder * Add StringComparison to file/directory extensions, with hearistic for default for IsSubPathOf * update tests * Address a bunch of code-analysis quick fixes (#1761)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.