-
Notifications
You must be signed in to change notification settings - Fork 188
[8.18] (backport #9560) Fix/5871 redact secrets in diagnostics #9598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* fix(5871): added secret marker func * fix(5871): added redaction marker test * fix(5871): added secret marker in coordinator * fix(5871): added secret marker func in coordinator unit tests * fix(5871): update redactMap to handle redaction markers * fix(5871): update redactmap tests * fix(5871): update diagnostics integration test * fix(5871): udpate inspect command to inject redaction markers * fix(5871): add changelog fragment (cherry picked from commit a44e87a) # Conflicts: # internal/pkg/agent/application/coordinator/coordinator_unit_test.go
Cherry-pick of a44e87a has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
|
💚 Build Succeeded
History
cc @kaanyalti |
This pull request has not been merged yet. Could you please review and merge it @kaanyalti? 🙏 |
What does this PR do?
Updates diagnostics redaction process to redact secrets from pre-config, computed-config, components-expected and components-actual files in the diagnostics archive
Why is it important?
This pr increases the scope of the redaction to all files where they may be exposed
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files./changelog/fragments
using the changelog toolDisruptive User Impact
none
How to test this PR locally
This is an automatic backport of pull request #9560 done by [Mergify](https://mergify.com).