fix(nsis): undefined vars when customCheckAppRunning is defined #9245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add a changeset to this using |
dlon
force-pushed
the
fix-undefined-vars-nsis
branch
from
340fa43 to
4217fe8
Compare
🦋 Changeset detectedLatest commit: b00d940 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sure. Done |
mmaietta
reviewed
Aug 10, 2025
packages/app-builder-lib/templates/nsis/include/allowOnlyOneInstallerInstance.nsh
Outdated
Show resolved
Hide resolved
dlon
force-pushed
the
fix-undefined-vars-nsis
branch
from
4217fe8 to
1784017
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if your NSIS script defines
customCheckAppRunning, building fails withVariable "CmdPath" not referenced or never set, wasting memory!. PR fixes this by not always declaring the unused variables.