Skip to content

Duplicate error msg fix for IP address field #9647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Duplicate error msg fix for IP address field #9647

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3681824
Duplicate error msg fix for IP address field
dakshbhayana11811137 Feb 9, 2025
08aba54
WIP
dakshbhayana11811137 Feb 10, 2025
ec927c9
Refactored Test cases for GenericIPAddress Field
dakshbhayana11811137 Feb 11, 2025
6128db6
Refactored Test Cases with additional models and Serializers
dakshbhayana11811137 Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion rest_framework/utils/field_mapping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,8 +207,10 @@ def get_field_kwargs(field_name, model_field):
if isinstance(model_field, models.GenericIPAddressField):
validator_kwarg = [
validator for validator in validator_kwarg
if validator is not validators.validate_ipv46_address
if validator not in [validators.validate_ipv46_address, validators.validate_ipv6_address, validators.validate_ipv4_address]
]
kwargs['protocol'] = getattr(model_field, 'protocol', 'both')

# Our decimal validation is handled in the field code, not validator code.
if isinstance(model_field, models.DecimalField):
validator_kwarg = [
Expand Down
Loading