Skip to content

fix(logs): ignore non-action logs for standalone #6605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dxtym
Copy link

@dxtym dxtym commented Jul 26, 2025

What type of PR is this?

Bug fix

What this PR does / why we need it:

This PR removes non-actionable error logs for standalone mode for the following methods:

  • DeleteRateLimitInfra
  • processOIDCHMACSecret
  • processEnvoyTLSSecret
  • Translate

Instead, the error logs are now emitted when the provider type equals Kubernetes.

Which issue(s) this PR fixes:

Fixes #6596

Release Notes: Yes

@dxtym dxtym requested a review from a team as a code owner July 26, 2025 20:08
zhaohuabing and others added 3 commits July 27, 2025 01:10
…tener drain (envoyproxy#6580)

use per-route configuration for session persistence to avoid listener darin

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: dxtym <dilmurod.abdusamadov2004@gmail.com>
Signed-off-by: dxtym <dilmurod.abdusamadov2004@gmail.com>
Signed-off-by: dxtym <dilmurod.abdusamadov2004@gmail.com>
Signed-off-by: Dilmurod <100064552+dxtym@users.noreply.github.com>
@dxtym
Copy link
Author

dxtym commented Jul 26, 2025

I'm sorry for a little mess in between commits; I was trying to figure out things with DCO. 🙏

Copy link

codecov bot commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 34.61538% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.96%. Comparing base (f5cdc1e) to head (532ea94).
⚠️ Report is 52 commits behind head on main.

Files with missing lines Patch % Lines
internal/provider/kubernetes/controller.go 52.94% 6 Missing and 2 partials ⚠️
internal/gatewayapi/runner/runner.go 0.00% 5 Missing ⚠️
internal/infrastructure/host/ratelimit_infra.go 0.00% 4 Missing ⚠️

❌ Your patch check has failed because the patch coverage (34.61%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6605      +/-   ##
==========================================
- Coverage   70.99%   70.96%   -0.04%     
==========================================
  Files         225      225              
  Lines       39043    39051       +8     
==========================================
- Hits        27720    27713       -7     
- Misses       9714     9727      +13     
- Partials     1609     1611       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

standalone mode always emits error logs that are not actionable or fixable by users
2 participants