p2p/discover: add discv5 invalid findnodes result test cases #32481
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #32470.
What
eth/protocols/snap/sync_test.go
from 1m to 10s.TestUDPv5_findnodeCall_InvalidNodes
covers:0.0.0.0
) → ignored<=1024
) → ignoredWhy
verifyResponseNode
rules (UDP must be >1024).How it’s validated
go test ./p2p/discover -count=1 -timeout=300s
→ okgo test ./eth/protocols/snap -count=1 -timeout=600s
→ okgo run build/ci.go lint
→ 0 issues on modified files.Notes
enode.ValidSchemesForTesting
(which includes the “null” scheme), so records signed withenode.SignNull
are signature-valid; failures here are due to IP/port validation inverifyResponseNode
andnetutil.CheckRelayAddr
.