Fix: Extend dayjs calendar plugin #200
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the missing extension for the calendar plugin in dayjs inside the datetime-picker.tsx file. Without this, calling dayjs(currentDate).calendar(calendar) results in a runtime TypeError: calendar is not a function. Extending the plugin fixes the crash, especially after Expo Prebuild or in native Dev Client setups where dayjs plugins must be manually extended. Thank you for your awesome work on this package! 🙌
|
As an expo user i can confirm this works properly |
|
@farhoudshapouran hey! can you please review this changes as its a huge blocker for expo sdk 53 users |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing extension for the calendar plugin in dayjs inside the datetime-picker.tsx file. Without this, calling dayjs(currentDate).calendar(calendar) results in a runtime TypeError: calendar is not a function.
Extending the plugin fixes the crash, especially after Expo Prebuild or in native Dev Client setups where dayjs plugins must be manually extended.
Thank you for your awesome work on this package! 🙌