♻️ Changing all status codes from raw numbers to using constants from status
#1624
+113
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deh/full-stack-fastapi-template into refactor-status-code
This comment was marked as resolved.
This comment was marked as resolved.
alejsdev
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Thank you, @YuriiMotov. |
YuriiMotov
changed the title
status
YuriiMotov
approved these changes
Sep 4, 2025
There was a problem hiding this comment.
LGTM
Still not sure about ranges.
I think we should leave numbers for
assert 200 <= r.status_code < 300But these changes are in separate commit. Can be easily reverted
@javadzarezadeh, thanks again!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that using status codes via FastAPI (Starlette, actually!) instead of using raw numbers is more readable, consistent, and makes development easier.
Re-request from PR #1319.