✅ Fix incorrect mocking in unit tests (issue #1780) #1781
Conversation
YuriiMotov
changed the title
There was a problem hiding this comment.
LGTM
I suggest removing several lines to simplify tests (I tested it locally - it doesn't break tests).
Currently if you replace session.exec(select(1)) in this line with pass, this assertion will not fail as it's expected.
This PR fixes mocking the Session and after applying it, that test will not only ensure that there was no exception in init, but also that select(1) was actually called.
The same for https://github.com/fastapi/full-stack-fastapi-template/blob/master/backend/app/tests/scripts/test_test_pre_start.py
@vicaya, thank you!
Could you please take a look at my suggested changes?
|
|
||
| from sqlmodel import select | ||
|
|
||
| import app.tests_pre_start # noqa: F401 |
There was a problem hiding this comment.
| import app.tests_pre_start # noqa: F401 |
I think this line is not needed
|
|
||
| from sqlmodel import select | ||
|
|
||
| import app.backend_pre_start # noqa: F401 |
There was a problem hiding this comment.
| import app.backend_pre_start # noqa: F401 |
I think this line is not needed
| exec_mock = MagicMock(return_value=True) | ||
| session_mock.configure_mock(**{"exec.return_value": exec_mock}) | ||
| session_mock.__enter__.return_value = session_mock | ||
| session_mock.exec = Mock() |
There was a problem hiding this comment.
| session_mock.exec = Mock() |
I think this line is not needed
| exec_mock = MagicMock(return_value=True) | ||
| session_mock.configure_mock(**{"exec.return_value": exec_mock}) | ||
| session_mock.__enter__.return_value = session_mock | ||
| session_mock.exec = Mock() |
There was a problem hiding this comment.
| session_mock.exec = Mock() |
I think this line is not needed
YuriiMotov
changed the title
Fix issue #1780: the 2
test_init_successful_connectiontests were basically noops due to misuse of MagicMock.The errors went undetected until python 3.12+ tightened up the MagicMock implementation.