InsertSlideAt not working as expected #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…index properly. Added a Unit testing project to exercise that code. commented out the documentation build as it builds to a hard coded path that doesn't exist on all machines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The InsertSlideAt method was always appending as the current index was not being properly calculated. Added 2 lines to calculate the current index correctly.
Added a unit test project for repeatable unit tests and added 5 tests to exercise the updated code.
Commented out the documentation build in 2 projects as this makes it impossible for people without a D drive to build the projects and solution. A relative path to the solution might be a better option here (something like ../../ that could exist outside of the code tree but would be guaranteed to exist).
The existing "FileFormat.Slides-Test" project referenced a package in the code that wasn't referenced by the project, so I commented that out.
Added NewtonSoft.Json to the FileFormat.Slides.Common project so that it could compile.
Added the standard .Net gitignore file so that commits don't attempt to commit bins and such.