[wgpu] Improve buffer mapping errors and allow aliasing immutable borrows #8150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
force-pushed
the
cw/buffer-mapping
branch
2 times, most recently
from
124daab to
54ea66f
Compare
kpreid
reviewed
Aug 26, 2025
cwfitzgerald
force-pushed
the
cw/buffer-mapping
branch
from
54ea66f to
5b3b32a
Compare
kpreid
reviewed
Aug 27, 2025
kpreid
approved these changes
Aug 27, 2025
cwfitzgerald
force-pushed
the
cw/buffer-mapping
branch
from
5b3b32a to
19203ae
Compare
Wumpf
approved these changes
Sep 1, 2025
Wumpf
requested changes
Sep 1, 2025
| @@ -125,6 +125,7 @@ By @cwfitzgerald in [#8162](https://github.com/gfx-rs/wgpu/pull/8162). | |||
| By @kpreid in [#8011](https://github.com/gfx-rs/wgpu/pull/8011). | |||
| - Make a compacted hal acceleration structure inherit a label from the base BLAS. By @Vecvec in [#8103](https://github.com/gfx-rs/wgpu/pull/8103). | |||
| - The limits requested for a device must now satisfy `min_subgroup_size <= max_subgroup_size`. By @andyleiserson in [#8085](https://github.com/gfx-rs/wgpu/pull/8085). | |||
| - Improve errors when buffer mapping is done incorrectly. Allow aliasing immutable [`BufferViews`]. By @cwfitzgerald in [#8150](https://github.com/gfx-rs/wgpu/pull/8150). | |||
There was a problem hiding this comment.
let's add a highlight for this & removed lifetimes on buffer mappings. If you're used to working around these this thing is a lifechanger!
|
ah sorry, didn't realize that. Up to you then |
Wumpf
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Thought I found a bug, realized I was holding it wrong but I was in there anyway so I fixed some stuff
Description
This does three things:
#[track_caller]annotations.Testing
As this has consequences for soundness, I added a bunch of tests. I checked the coverage report and all codepath I changed are covered in the tests.
Squash or Rebase?
Dontcare