Skip to content

Conversation

Jony-Jas
Copy link
Contributor

Closes #1227

Created PullMirror model and get methods to support the PullMirror API endpoint

  • List getPullMirrors(final Object projectIdOrPath)
  • Pager getPullMirrors(final Object projectIdOrPath, int itemsPerPage)

Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, a small addition is needed

private Date lastSuccessfulUpdateAt;
private Date lastUpdateAt;
private Date lastUpdateStartedAt;
private String updatedStatus;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jony-Jas according to the documentation https://docs.gitlab.com/api/project_pull_mirroring/#get-a-projects-pull-mirror-details the field is named update_status in the JSON.

Do you confirm? (sometimes the docs is wrong)

Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me this is ready to be merged.

Waiting for potential feedback from contributors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: add "Pull mirror API"
2 participants