Remove unused parameter in string.repeat_loop #852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosephTLyons
changed the title
JosephTLyons
force-pushed
the
Remove-unused-parametere-in-string.repeat_loop
branch
from
1e57e6f to
628f2e1
Compare
|
Nice catch! I'm working on a PR so that this will become a compiler warning gleam-lang/gleam#4893 |
|
Amazing! I was working up the courage to suggest a lint for this exact thing, after opening this PR! 😅 Curious if this surfaces any other cases in the |
|
Nope nothing popped up! |
JosephTLyons
deleted the
Remove-unused-parametere-in-string.repeat_loop
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking over the
stringmodule when I realized the changes I made forstring.repeathad left an unnecessary parameter in thestring.repeat_loopfunction.