Carthage fixes #157
Open
Carthage fixes #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hold up, I had looked wrong at the project architecture. The solution is correct, but this is going to need some more changes to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carthage only looks at the .xcodeproj to look for the scheme to build, but said scheme in BetterSegmentedControl was looking at the target framework built in the Pods.xcodeproj.
So if you were using the .xcworkspace, you wouldn't notice anything, but if you opened the .xcodeproj in Xcode, you wouldn't be able to build the framework.
This adds a new target in the main xcodeproj that builds the framework, and the main schema now looks at that instead.
Closes #105