Skip to content

Conversation

panmari
Copy link
Collaborator

@panmari panmari commented Aug 30, 2025

No description provided.

@panmari
Copy link
Collaborator Author

panmari commented Sep 2, 2025 via email

@jmr
Copy link
Collaborator

jmr commented Sep 2, 2025

Markdown auto-formatter in VS code did this. Do you have a formatter that would keep the style as-is?

The Google mdformat is very close and only wants to change the badge links and the supporting types table.

@jmr
Copy link
Collaborator

jmr commented Sep 4, 2025

Markdown auto-formatter in VS code did this. Do you have a formatter that would keep the style as-is?

The Google mdformat is very close and only wants to change the badge links and the supporting types table.

Alternatively, what formatter does vscode use? It there a way to run it without vscode?

@panmari
Copy link
Collaborator Author

panmari commented Sep 4, 2025

I just looked into this. The Google markdown formatter is not open source, so is quite cumbersome to run for external folks. I just used the most popular markdown extension at https://marketplace.visualstudio.com/items?itemName=yzhang.markdown-all-in-one.

@panmari
Copy link
Collaborator Author

panmari commented Sep 4, 2025

It also formats the tables below, which I ended up reverting. Here's the CL with all formatting changes: https://github.com/golang/geo/compare/master...panmari:geo:more_formatting?expand=1

@jmr
Copy link
Collaborator

jmr commented Sep 8, 2025

Can you revert the formatting changes, just add the earth docs, and we'll deal with markdown formatting separately?

@panmari panmari force-pushed the s2earth branch 3 times, most recently from e68f196 to c2f3116 Compare September 9, 2025 19:44
@panmari panmari requested a review from jmr September 11, 2025 07:14
@jmr jmr merged commit fe10c1d into golang:master Sep 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants