Skip to content

Generate PR suggestions when formatting is wrong #2396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Generate PR suggestions when formatting is wrong #2396

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
223d565
Generate PR suggestions when formatting is wrong
mgeisler Oct 5, 2024
4155f60
Apply suggestions from code review
mgeisler Oct 5, 2024
23fc1fb
Update README.md
mgeisler Oct 5, 2024
b08e5c3
Introduce extra whitespace
mgeisler Oct 6, 2024
c41e9ea
Update .github/workflows/build.yml
mgeisler Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,22 @@ jobs:
run: |
sudo apt update
sudo apt install gettext yapf3
curl -fsSL https://dprint.dev/install.sh | sh
echo "/home/runner/.dprint/bin" >> $GITHUB_PATH

- name: Install nightly rustfmt
run: |
rustup default nightly
rustup component add rustfmt

- name: Check formatting
uses: dprint/check@v2.2
- name: Format the project
run: dprint fmt

- name: Add PR suggestions for formatting changes
uses: parkerbxyz/suggest-changes@v1

- name: Check for changes
run: git diff --exit-code

typos:
runs-on: ubuntu-latest
Expand Down