Skip to content
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
103 changes: 73 additions & 30 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,31 +3,45 @@ name: Publish
# See also TRANSLATIONS.md.

on:
pull_request:
push:
branches:
- main
workflow_dispatch:

permissions:
contents: read
pages: write
id-token: write

# Allow one concurrent deployment
concurrency:
group: pages
cancel-in-progress: true

env:
CARGO_TERM_COLOR: always
# Update the language picker in index.hbs to link new languages.
LANGUAGES: ar bn da de el es fa fr id it ja ko pl pt-BR ro ru tr uk vi zh-CN zh-TW

jobs:
publish:
environment:
name: github-pages
url: ${{ steps.deployment.outputs.page_url }}
create-translation:
strategy:
matrix:
language:
[
"en",
"ar",
"bn",
Comment on lines +20 to +24
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I understand of YAML, this can be simplified to

Suggested change
language:
[
"en",
"ar",
"bn",
language:
- "en"
- "ar"
- "bn"

and so on, which seems ever so slightly more high level.

"da",
"de",
"el",
"es",
"fa",
"fr",
"id",
"it",
"ja",
"ko",
"pl",
"pt-BR",
"ro",
"ru",
"tr",
"uk",
"vi",
"zh-CN",
"zh-TW",
]
runs-on: ubuntu-latest
steps:
- name: Checkout
Expand All @@ -50,14 +64,49 @@ jobs:
uses: ./.github/workflows/install-mdbook

- name: Build course in English
if: matrix.language == 'en'
run: .github/workflows/build.sh en book

- name: Build all translations
- name: Build ${{ matrix.language }} translation
if: matrix.language != 'en'
run: |
for po_lang in ${{ env.LANGUAGES }}; do
.github/workflows/build.sh $po_lang book/$po_lang
mv book/$po_lang/html book/html/$po_lang
done
.github/workflows/build.sh ${{ matrix.language }} book/${{ matrix.language }}
mkdir book/html
mv book/${{ matrix.language }}/html book/html/${{ matrix.language }}

- name: Upload translation
uses: actions/upload-artifact@v4
with:
name: comprehensive-rust-${{ matrix.language }}
path: book/

publish:
runs-on: ubuntu-latest
needs: create-translation
steps:
- name: Checkout
uses: actions/checkout@v4

- name: Update Rust
run: rustup update

- name: Setup Rust cache
uses: ./.github/workflows/setup-rust-cache

- name: Install Gettext
run: |
sudo apt update
sudo apt install gettext

- name: Install mdbook
uses: ./.github/workflows/install-mdbook
Comment on lines +90 to +102
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small question: do we need to install Rust, mdbook, and the Gettext tools here? I would guess not since everything is built already, no? We're just putting the pieces together and uploading it all?


- name: Download all translations
uses: actions/download-artifact@v4
with:
path: book/
pattern: comprehensive-rust-*
merge-multiple: true

- name: Build translation report
run: i18n-report report book/html/translation-report.html po/*.po
Expand All @@ -69,14 +118,8 @@ jobs:
for file in synced-po/*.po; do msgmerge --update $file synced-po/messages.pot ; done
i18n-report report book/html/synced-translation-report.html synced-po/*.po

- name: Setup Pages
uses: actions/configure-pages@v5

- name: Upload artifact
uses: actions/upload-pages-artifact@v3
- name: Upload all translations (for verification)
uses: actions/upload-artifact@v4
with:
path: book/html

- name: Deploy to GitHub Pages
id: deployment
uses: actions/deploy-pages@v4
Comment on lines -80 to -82
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised this went away? Is this not the most important part, so to speak? 😄

name: comprehensive-rust-all
path: book/
Loading