Skip to content

Conversation

TheRealNoob
Copy link
Contributor

What this PR does / why we need it:
Adds helm-unittest support. Helpful for local static testing. I added one test for now. I didn't want to overwhelm this PR with dozens of test cases. Plus if I can get it out quicker maybe others will build upon it.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@TheRealNoob TheRealNoob requested a review from a team as a code owner August 29, 2025 22:10
@TheRealNoob TheRealNoob marked this pull request as draft September 3, 2025 16:00
* fix "install unittest" CI step
* update extra-manifests unittest
@TheRealNoob TheRealNoob marked this pull request as ready for review September 3, 2025 16:40
Copy link
Contributor

@jkroepke jkroepke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look okay (but we have to wait for CI)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to much knowledge about cloud/agents.md I skip the review here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants