-
Notifications
You must be signed in to change notification settings - Fork 3.8k
feat(helm): add configurable livenessProbe to single binary StatefulSet #19072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Jayclifford345
merged 12 commits into
grafana:main
from
unique-jakub:feat/single-binary-liveness-probe
Sep 9, 2025
Merged
feat(helm): add configurable livenessProbe to single binary StatefulSet #19072
Jayclifford345
merged 12 commits into
grafana:main
from
unique-jakub:feat/single-binary-liveness-probe
Sep 9, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add livenessProbe configuration option to singleBinary section in values.yaml - Maintains consistency with other Loki components' probe configuration patterns
2a14288
to
4409ca0
Compare
Signed-off-by: unique-jakub <jakub@unique.ch>
jkroepke
reviewed
Sep 5, 2025
Co-authored-by: Jan-Otto Kröpke <mail@jkroepke.de> Signed-off-by: unique-jakub <jakub@unique.ch>
jkroepke
reviewed
Sep 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com>
Jayclifford345
approved these changes
Sep 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds support for configurable
livenessProbe
to the single binary StatefulSet deployment mode. Currently, the single binary StatefulSet only supportsreadinessProbe
but lackslivenessProbe
configuration, which is available in other Loki components.The implementation uses the global
loki.livenessProbe
configuration (similar to how other components like distributor, querier, and index-gateway handle probes), ensuring consistency across the entire chart.This enables users to:
Which issue(s) this PR fixes:
Fixes #15191
Special notes for your reviewer:
{{- with .Values.loki.livenessProbe }}
loki.livenessProbe
defaults to{}
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR