Workaround for tokens that start with Unicode BOM #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BOM is swallowed by JSONSerialization.jsonObject() because it thinks it signals the encoding in use. This workaround duplicates BOM sequences that follow a quote character. Fixes #116 Fixes #88 Fixes ml-explore/mlx-swift-examples#50
FL33TW00D
approved these changes
Sep 12, 2025
|
@FL33TW00D lol, it's essentially what you suggested here, only in a more hackish way - we duplicate the BOM rather than replacing it with something else and then undoing the replacement |
Damn completely forgot about that! Much better approach to duplicate than add a random marker. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BOM is swallowed by
JSONSerialization.jsonObject()because it thinks it signals the encoding in use. This workaround duplicates BOM sequences that follow a quote character.Fixes #116
Fixes #88
Fixes ml-explore/mlx-swift-examples#50